Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add load_pickle mode and create_pickle_in_report option #205

Merged
merged 8 commits into from
Jan 2, 2025

Conversation

stefansc1
Copy link
Collaborator

Implements #116

Requires dill, as standard pickle can't handle parametrized Trip.consumption.calculate_consumption.interpol_function

@stefansc1 stefansc1 requested a review from j-brendel July 31, 2024 10:40
simba/simulate.py Outdated Show resolved Hide resolved
simba/simulate.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@PaulScheerRLI PaulScheerRLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider my suggestions.
Also dev must be merged

stefan.schirmeister added 2 commits December 11, 2024 11:22
- enforce modes list in util.get_args, remove cast in simulate
- change argument name from load_pickle to load_pickle_path
- if load_pickle is first mode, there must be further modes
@stefansc1 stefansc1 merged commit 2e1b290 into dev Jan 2, 2025
6 checks passed
@stefansc1 stefansc1 deleted the feature/pickle_mode branch January 2, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants