generated from rl-institut/rli_template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/add tests #357
Draft
MaGering
wants to merge
64
commits into
dev
Choose a base branch
from
features/add_tests
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Features/add tests #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main test function and helper scripts are in this script Rule lists move to the respective output test script
@Stefanie08, here are some open TODOs:
|
MaGering
commented
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Stefanie08,
could you please check my comments? Thank you! :)
MaGering
commented
Jun 3, 2024
…just code in testing_pipeline.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR tests of the pipeline are added.
The aim is to test each of oemof-B3's rules. So far we collected the rules we had to test in this excel table. Now we want implement tests for this.
I already created a first draft, where I started by testing the rule "create_empty_scalars".
The basic idea is to check if the output, which would be created by the rule, already exists. If so it is renamed first. Then the rule is run and it is checked if there is an output from snakemake and if the path exists. If so, the created output is deleted and the original file is named back. There is a try and exception around this, to make sure, that original data is named back no matter what error there might occure from the renaming on.