Fix build on NetBSD by removing __NetBSD__ workaround
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove __NetBSD__ workaround for old versions of NetBSD librefuse. Here's an explanation why it's problematic: This filesystem declares that it wants FUSE 2.6 API: > #define FUSE_USE_VERSION 26 In the past NetBSD had a broken implementation of FUSE API. It used to expose FUSE 3.0 API even when 2.6 was requested. Since these two versions have incompatible fuse_new(3), rvaultfs.c uses FUSE 3.0 API as a workaround. However, NetBSD no longer has this issue and now it correctly exposes FUSE 2.6 API when requested so. Trying to use 3.0 API results in a compilation error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
__NetBSD__workaround for old versions of NetBSD librefuse. Here's an explanation why it's problematic:This filesystem declares that it wants FUSE 2.6 API:
In the past NetBSD had a broken implementation of FUSE API. It used to expose FUSE 3.0 API even when 2.6 was requested. Since these two versions have incompatible
fuse_new(3),rvaultfs.cuses FUSE 3.0 API as a workaround. However, NetBSD no longer has this issue and now it correctly exposes FUSE 2.6 API when requested so. Trying to use 3.0 API results in a compilation error.