-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present SRS metadata with a colored pill, instead of raw text attributes #134
base: master
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I like it but am a bit conflicted :) Regarding injecting CSS - I think it's ok to do so, as long as people can override styles (so we should have doc on those) Also a majority of my prompts would be in 1+ month :) I'd like more granularity then that (probably up to a few years) |
As a curiousity/fyi - another way to make the thing render in "special way" is to surround it with double |
src/ts/core/srs/srs.ts
Outdated
.map(days => intervalStyle(`${days}.`, `${days} days`)) | ||
.join('\n')} | ||
${range(7, 30) | ||
.map(days => intervalStyle(`${days}.`, `${Math.floor(days / 7)} weeks`)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually like to see the fractions here (to a first decimal) (same for months/years)
the days should be shifted in +1 direction for this as the fractions are rounded up for the purposes of scheduling. so interval 4.2 would result in scheduling in 5 days. |
fee13f3
to
ffbae8c
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Is it possible to add css buttons that can do the function of ctrl-shift-x ? for how well recall is? |
It's possible, but it'd involve more then just CSS, it'd require custom rendering of blocks. Which is not trivial (not that complicated either, but requires some work) |
b5d5fa7
to
b1f66fb
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@tntmarket are you just updating the current version with latest changes from master, or did you find a way to make it work better? |
Oh sorry, I've just been pushing my personal customizations to this branch, I'll start using another branch |
This reverts to the
[[]]
style of block properties, in order to be able to fully hide the metadata with css. The metadata is still readable if you edit the block.It displays the review interval, and colors the pill according to the ease factor.
I'm not sure if I should include the css in roam-toolkit itself. Maybe better to link to some example css in the documentation, in case it looks ugly with certain css themes, or if people want to tune the presentation based on values.
Here is the full css being generated: https://gist.github.com/tntmarket/9dc7179e9c8c0357b87fbbeed3eedfc9