fix: some dead code

roblox-csharp · Jan 7, 2025 · 155a587 · 155a587
1 parent 4baff3e
commit 155a587
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 28 deletions.
diff --git a/RobloxCS.Luau/AST/Assignment.cs b/RobloxCS.Luau/AST/Assignment.cs
@@ -3,7 +3,7 @@
     public sealed class Assignment : Expression
     {
         public AssignmentTarget Target { get; }
-        public Expression Value;
+        public Expression Value { get; private set; }
 
         public Assignment(AssignmentTarget target, Expression value)
         {

diff --git a/RobloxCS.Luau/AST/Block.cs b/RobloxCS.Luau/AST/Block.cs
@@ -7,14 +7,9 @@ public class Block : Statement
         public Block(List<Statement> statements)
         {
             Statements = statements;
+            AddChildren(Statements);
         }
 
-        public override void Render(LuauWriter luau)
-        {
-            foreach (var statement in Statements)
-            {
-                statement.Render(luau);
-            }
-        }
+        public override void Render(LuauWriter luau) => luau.WriteNodes(Statements);
     }
 }
diff --git a/RobloxCS.Luau/AST/TypeCast.cs b/RobloxCS.Luau/AST/TypeCast.cs
@@ -11,11 +11,7 @@ public TypeCast(Expression expression, TypeRef type)
             Type = type;
         }
 
-        public override void Render(LuauWriter luau)
-        {
-            Expression.Render(luau);
-            luau.Write(" :: ");
-            Type.Render(luau);
-        }
+        public override void Render(LuauWriter luau) =>
+            luau.WriteTypeCast(Expression, Type);
     }
 }
diff --git a/RobloxCS.Luau/AST/VariableList.cs b/RobloxCS.Luau/AST/VariableList.cs
@@ -10,12 +10,6 @@ public VariableList(List<Variable> variables)
             AddChildren(Variables);
         }
 
-        public override void Render(LuauWriter luau)
-        {
-            foreach (var variable in Variables)
-            {
-                variable.Render(luau);
-            }
-        }
+        public override void Render(LuauWriter luau) => luau.WriteNodes(Variables);
     }
 }
diff --git a/RobloxCS.Luau/LuauWriter.cs b/RobloxCS.Luau/LuauWriter.cs
@@ -10,24 +10,21 @@ public string Render(AST ast)
 
         public void WriteNodesCommaSeparated<TNode>(List<TNode> nodes) where TNode : Node
         {
+            var index = 0;
             foreach (var node in nodes)
             {
                 node.Render(this);
-                if (node != nodes.Last())
-                {
+                if (index++ != nodes.Count - 1)
                     Write(", ");
-                }
             }
         }
+
         public void WriteNodes<TNode>(List<TNode> nodes) where TNode : Node
         {
             foreach (var node in nodes)
-            {
                 node.Render(this);
-            }
         }
 
-
         public void WriteRequire(string requirePath)
         {
             WriteLine($"require({requirePath})");
@@ -132,7 +129,10 @@ public void WriteTypeCast(Expression expression, TypeRef type)
             type.Render(this);
         }
 
-        // wtf is this for??? i literally forgot
+        /// <summary>
+        /// Writes statements are descendants of <see cref="node"/>.
+        /// This is used in cases like a[b++] where the indexer has code that needs to be rendered outside the brackets.
+        /// </summary> 
         public void WriteDescendantStatements(ref Node node)
         {
             if (node.Parent is not Variable && node is not Argument)