-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some compiler warnings #179
Conversation
Thanks @pauldreik ! @GiulioRomualdi |
the CI failures seem unrelated to this PR. |
Exactly, they are fixed in #171 . |
when returning by value, the const qualifier is ignored.
37655fb
to
4cd09de
Compare
Hi @pauldreik 😃 Thank you for your contribution 🎉 |
@GiulioRomualdi happy to help! there was a build failure inside catch2 unrelated to osqp-eigen so I updated the catch2 version. I am unfortunately not allowed to run CI so please approve the CI run. |
Working 🎉 I will squash and merge |
I am unsure if I use the ADD_WARNINGS_CONFIGURATION_TO_TARGETS macro correct - I am surprised that it wasn't used anywhere in the code base.