Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compiler warnings #179

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

pauldreik
Copy link
Contributor

I am unsure if I use the ADD_WARNINGS_CONFIGURATION_TO_TARGETS macro correct - I am surprised that it wasn't used anywhere in the code base.

@pauldreik pauldreik changed the title Fix warning Fix warnings Dec 13, 2024
@pauldreik pauldreik changed the title Fix warnings Fix some compiler warnings Dec 13, 2024
@traversaro
Copy link
Member

Thanks @pauldreik ! @GiulioRomualdi

@pauldreik
Copy link
Contributor Author

pauldreik commented Dec 13, 2024

the CI failures seem unrelated to this PR.

@traversaro
Copy link
Member

the CI failures seem unrelated to this PR.

Exactly, they are fixed in #171 .

@GiulioRomualdi
Copy link
Member

Hi @pauldreik 😃 Thank you for your contribution 🎉
I rebased your PR on top of master so #171 will be effective

@pauldreik
Copy link
Contributor Author

@GiulioRomualdi happy to help!

there was a build failure inside catch2 unrelated to osqp-eigen so I updated the catch2 version. I am unfortunately not allowed to run CI so please approve the CI run.

@GiulioRomualdi
Copy link
Member

@GiulioRomualdi happy to help!

there was a build failure inside catch2 unrelated to osqp-eigen so I updated the catch2 version. I am unfortunately not allowed to run CI so please approve the CI run.

Working 🎉 I will squash and merge

@GiulioRomualdi GiulioRomualdi merged commit 3fc702c into robotology:master Jan 7, 2025
12 checks passed
@pauldreik pauldreik deleted the fix_warning branch January 7, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants