Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lets use lib frodo #386

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Lets use lib frodo #386

wants to merge 7 commits into from

Conversation

adam-cyclones
Copy link

Okay so before we publish frodo-lib, this repo uses the git repo directly as a npm package to install, so it acts the same, we just have this frodo-lib in the registry yet.

The PR

  • adds the dependency
  • removes ops
  • changes all the imports
  • @vscheuber removes Console, print and tables and other pretty things (comments it out) so that CLI can find its own location to re-implement this specific code

TESTERS NEEDED!

@adam-cyclones adam-cyclones requested review from atomicsamurai and vscheuber and removed request for atomicsamurai August 15, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vscheuber vscheuber Awaiting requested review from vscheuber

@atomicsamurai atomicsamurai Awaiting requested review from atomicsamurai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adam-cyclones