Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test aggregates component AB#32035 #1897

Merged
merged 9 commits into from
Jan 22, 2025

Conversation

arsforza
Copy link
Contributor

@arsforza arsforza commented Jan 6, 2025

Describe your changes

Brief description of your changes - not in-depth because the bulk of the description should be in the task on DevOps.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. Any helpful instructions or clarifications...

@arsforza arsforza marked this pull request as draft January 6, 2025 09:55
@jannisvisser jannisvisser force-pushed the test.unit-aggregates-component branch from 15b919c to f0f6ddd Compare January 13, 2025 15:53
@jannisvisser jannisvisser marked this pull request as ready for review January 14, 2025 13:26
@jannisvisser jannisvisser changed the title WIP getAggregatesHeader test AB#32035 Unit test aggregates component AB#32035 Jan 14, 2025
@jannisvisser jannisvisser changed the title Unit test aggregates component AB#32035 DO NOT MERGE YET: Unit test aggregates component AB#32035 Jan 15, 2025
@jannisvisser
Copy link
Contributor

This should not be merged before upcoming release, as it will leave no time to prepare informing users about removing stop-trigger

@jannisvisser jannisvisser marked this pull request as draft January 20, 2025 08:55
@jannisvisser jannisvisser changed the title DO NOT MERGE YET: Unit test aggregates component AB#32035 Unit test aggregates component AB#32035 Jan 22, 2025
@jannisvisser jannisvisser marked this pull request as ready for review January 22, 2025 11:53
@jannisvisser jannisvisser force-pushed the test.unit-aggregates-component branch from 2aac8c7 to 83a1545 Compare January 22, 2025 11:56
@jannisvisser jannisvisser merged commit e9949c8 into master Jan 22, 2025
7 checks passed
@jannisvisser jannisvisser deleted the test.unit-aggregates-component branch January 22, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants