Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement V4::Starlink #101

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement V4::Starlink #101

wants to merge 4 commits into from

Conversation

mtking2
Copy link
Contributor

@mtking2 mtking2 commented Oct 17, 2021

Why?

Description

  • Support for two of the starlink endpoints
    • Get all starlink satellites
    • Get a specific starlink satellite by id

@buddydangerbot
Copy link

1 Warning
⚠️ This is a big PR eh? If possible, consider a small PR to help the code review process

Generated by 🚫 Danger

@rodolfobandeira rodolfobandeira self-requested a review October 18, 2021 00:08
invacuo
invacuo reviewed Oct 18, 2021
View reviewed changes
lib/spacex/v4/starlink.rb
@@ -0,0 +1,9 @@
module SPACEX
Copy link
Collaborator

@invacuo invacuo Oct 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class can go away if #100 is approved. The rest of the PR is still needed though. Thanks for all the help @mtking2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invacuo invacuo invacuo left review comments

@rodolfobandeira rodolfobandeira Awaiting requested review from rodolfobandeira

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest HacktoberFest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtking2 @buddydangerbot @invacuo @rodolfobandeira