Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement V4::Launches #98

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement V4::Launches #98

wants to merge 9 commits into from

Conversation

mtking2
Copy link
Contributor

@mtking2 mtking2 commented Oct 17, 2021

Why?

Description

  • Support for the new launch endpoints
    • Get all launches
    • Get a specific launch by id
    • Get latest launch
    • Get next launch
    • Get all upcoming launches
    • Get all past launches

@rodolfobandeira rodolfobandeira added the hacktoberfest HacktoberFest label Oct 17, 2021
@mtking2 mtking2 marked this pull request as ready for review October 17, 2021 16:41
@buddydangerbot
Copy link

1 Warning
⚠️ This is a big PR eh? If possible, consider a small PR to help the code review process

Rubocop violations

File Line Reason
spec/spacex/v4/launches_spec.rb 147 Line is too long. [682/264]

Generated by 🚫 Danger

@rodolfobandeira rodolfobandeira self-requested a review October 18, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodolfobandeira rodolfobandeira Awaiting requested review from rodolfobandeira

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest HacktoberFest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtking2 @buddydangerbot @rodolfobandeira