Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update react-scripts dep to be a dev dep and not break on newer typescript projects #59

Closed

Conversation

jaredzwick
Copy link

Description

Changed react-scripts to dev dep

Resolved issues

#58
Closes #1

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@roerohan
Copy link
Owner

Hey @jaredzwick , thanks for raising this PR!

I went through it, I don't think react-scripts can be a dev dependency. For more, check this out. Let me know if you think I'm wrong, thanks again!

@roerohan roerohan closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants