Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Update GitHub Actions version #2461

Merged

Conversation

Gumichocopengin8
Copy link
Contributor

Summary

Update actions/xxxxx@vx to actions/xxxxxx@v3 or 6 since Node12 will be out of life after Aril 30, 2022 [Reference].
actions/xxxx@v3 or actions/xxxx@v6 use Node16 whose support lasts until April 30, 2024.

Test Plan

Check if GitHub Actions workflows work well

@Gumichocopengin8 Gumichocopengin8 changed the title chore: update github actions version Update GitHub Actions version Apr 18, 2022
@Gumichocopengin8
Copy link
Contributor Author

Hello @ematipico,
Could you manually run the GitHub Actions to test this change?

@Gumichocopengin8
Copy link
Contributor Author

I couldn't see the GitHub Actions running at first but it was just invisible.
Could somebody run this flow again? I think the error, AWS_S3_BUCKET is not set. Quitting. comes from somewhere else. jakejarvis/s3-sync-action#53

@NicholasLYang
Copy link
Contributor

Appears to be a permissions issue. I'll see if we can fix that. But agreed, it shouldn't be a blocker for this PR

@Gumichocopengin8
Copy link
Contributor Author

@NicholasLYang Thanks

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaReiser MichaReiser merged commit 57f3f72 into rome:main Apr 19, 2022
@Gumichocopengin8 Gumichocopengin8 deleted the chore/github-actions-version branch April 19, 2022 06:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants