[RF] Refactor RooProdPdf for more concise code #17535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While trying to address the several GitHub issues related to integrals of RooProdPdfs, I saw some opportunities to refactor the code to avoid duplication, especially in `RooProdPdf::processProductTerm()`.
Introduce a single data structure to the RooProdPdf to carry around factorized term info. That makes it easier to understand, navigate, and refactor the code.
Test Results 18 files 18 suites 4d 19h 35m 25s ⏱️ Results for commit e024a43. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to address the several GitHub issues related to
integrals of RooProdPdfs, I saw some opportunities to refactor the code
to avoid duplication, especially in
RooProdPdf::processProductTerm().Besides refactoring to avoid code repetition, this PR includes commits that remove unnecessary commented-out lines with
std::cout, and to introduce proper datastructures to move data around theRooProdPdfhelper functions.