Skip to content

Commit

Permalink
still more fixes for the CRAN build.
Browse files Browse the repository at this point in the history
  • Loading branch information
gfinak committed Mar 13, 2019
1 parent 061de71 commit 47756b8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 12 deletions.
2 changes: 1 addition & 1 deletion CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
This package was submitted to CRAN on 2019-03-13.
Once it is accepted, delete this file and tag the release (commit a004265122).
Once it is accepted, delete this file and tag the release (commit 061de71309).
13 changes: 4 additions & 9 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
## Minor release 0.15.6
## Resubmission 0.15.6
* I have addresed remaining issues in the vignette and the test cases that were still trying write to the user's library causing failures on debian-gcc on CRAN for version 0.15.5
* I've tested with a read-only system and user R library to simulate the errors on the debian system.
* There is one remaining NOTE that is due to the way we load and test a package (using loadNamespace) built by DataPackageR in the vignettes.

## Test environments
* local OS X install (x86_64-apple-darwin16.7.0), R 3.6.0 (2019-03-07 r76210)
Expand All @@ -18,14 +17,10 @@

There were no ERRORs or WARNINGs

There was 1 NOTE:
N checking for unstated dependencies in vignettes ...
'library' or 'require' call not declared from: ‘mtcars20’
There was 1 NOTE

There was 1 NOTE when pandoc was absent:

NOTE:
Files ‘README.md’ or ‘NEWS.md’ cannot be checked without ‘pandoc’ being installed.
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Greg Finak <gfinak@fredhutch.org>'

## Downstream dependencies

Expand Down
5 changes: 3 additions & 2 deletions vignettes/usingDataPackageR.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,9 @@ The data set documentation will be accessible via `?cars_over_20`, and the data
dir.create(file.path(tempdir(),"lib"))
# Let's use the package we just created.
install.packages(file.path(tempdir(),"mtcars20_1.0.tar.gz"), type = "source", repos = NULL, lib = file.path(tempdir(),"lib"))
if(!"package:mtcars20"%in%search())
attachNamespace(loadNamespace('mtcars20',lib.loc = file.path(tempdir(),"lib"))) #use library() in your code
lns <- loadNamespace
if (!"package:mtcars20"%in%search())
attachNamespace(lns('mtcars20',lib.loc = file.path(tempdir(),"lib"))) #use library() in your code
data("cars_over_20") # load the data
cars_over_20 # now we can use it.
Expand Down

0 comments on commit 47756b8

Please sign in to comment.