Remove logging #163
Merged
Remove logging #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes logging while keeping the rest of DataPackageR behavior the same, except that the
logargument is now removed frompackage_build(). Normally it would be good to follow a deprecation process for that, but the argument was untested in the unit tests and it seems unlikely that anyone has been specifying a non-default value for it recently.Logging hasn't been used recently in practice, and is redundant with automatic NEWS.md updates, console messages, and version control. It added complexity to both DataPackageR and data packages and relied on dependency
futile.loggerwhich has not been updated since 2016.