Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update include paths of GPL #264

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Update include paths of GPL #264

merged 3 commits into from
Jan 15, 2025

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich marked this pull request as ready for review January 15, 2025 15:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (4b891e5) to head (b3c89af).

Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #264   +/-   ##
============================================
  Coverage        74.88%   74.88%           
============================================
  Files               24       24           
  Lines             1107     1107           
  Branches            86       86           
============================================
  Hits               829      829           
  Misses             231      231           
  Partials            47       47           
Flag Coverage Δ
unittests 74.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/control_filters/exponential_filter.hpp 68.42% <ø> (ø)
include/control_filters/low_pass_filter.hpp 59.37% <ø> (ø)
include/control_filters/rate_limiter.hpp 73.07% <ø> (ø)

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Jan 15, 2025
saikishor
saikishor previously approved these changes Jan 15, 2025
@saikishor
Copy link
Member

I don't understand why ABI is breaking here

@christophfroehlich
Copy link
Contributor Author

I don't understand why ABI is breaking here

ABI used main instead of testing, like we have in ros2_controllers for example

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to use testing here

@christophfroehlich christophfroehlich merged commit 4885811 into ros2-master Jan 15, 2025
24 of 27 checks passed
@christophfroehlich christophfroehlich deleted the update/gpl branch January 15, 2025 22:38
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

Copy link

mergify bot commented Jan 15, 2025

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 15, 2025
(cherry picked from commit 4885811)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants