Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set robot description parameter for controllers #477

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

annaborn
Copy link

@annaborn annaborn commented Jan 7, 2025

Hello,

this patch sets the robot description parameter, so it can be accessible from controllers.

Similar to the patch done for gazebo_ros2_control ros-controls/gazebo_ros2_control#277

Without the patch:

/controller_manager:
  joint_state_broadcaster.type
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  qos_overrides./parameter_events.publisher.depth
  qos_overrides./parameter_events.publisher.durability
  qos_overrides./parameter_events.publisher.history
  qos_overrides./parameter_events.publisher.reliability
  update_rate
  use_sim_time
/joint_state_broadcaster:
  extra_joints
  interfaces
  joints
  map_interface_to_joint_state.effort
  map_interface_to_joint_state.position
  map_interface_to_joint_state.velocity
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  update_rate
  use_local_topics
  use_sim_time

With the patch:

/controller_manager:
  joint_state_broadcaster.type
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  qos_overrides./parameter_events.publisher.depth
  qos_overrides./parameter_events.publisher.durability
  qos_overrides./parameter_events.publisher.history
  qos_overrides./parameter_events.publisher.reliability
  robot_description
  update_rate
  use_sim_time
/joint_state_broadcaster:
  extra_joints
  interfaces
  joints
  map_interface_to_joint_state.effort
  map_interface_to_joint_state.position
  map_interface_to_joint_state.velocity
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  robot_description
  update_rate
  use_local_topics
  use_sim_time

It will fix the open issue: #168

@ahcorde
@christophfroehlich

@annaborn annaborn requested a review from ahcorde as a code owner January 7, 2025 11:07
@annaborn annaborn changed the title Set robot description parameter to controllers Set robot description parameter for controllers Jan 7, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the failing tests are related to this PR. It does not fail on humble branch. gz sim is not shutting down here, which is different to #481

We don't need this on newer versions since it is parsed from the CM already, right? See ros-controls/ros2_control#1088

ign_ros2_control/src/ign_ros2_control_plugin.cpp Outdated Show resolved Hide resolved
@annaborn
Copy link
Author

Hello @christophfroehlich and @bmagyar ,
I would like to know what is the state of this pull request. How should we proceed, so it gets merged into humble branch? :)

annaborn and others added 2 commits January 27, 2025 12:30
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@ahcorde ahcorde merged commit e464e0f into ros-controls:humble Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants