Recheck intensity support when restarting the driver #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bad connection may lead us to falsely detect that intensity is not supported, before resetting the connection due to too many errors. On reset, we should recheck whether intensity is supported and not rely on the previous check.
|
@mferenduros am I missing something there or is the change simply in adding new variables that equal existing variables? |
|
Hi @tonybaltovski , The new variables behave differently from the old ones.
#57 describes the situation that this helps address |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for intensity/multiecho support may fail due to a bad connection (eg. if powering or connecting a laser with urg_node already running).
If the driver then resets to fix this bad connection, it should re-test for intensity/multiecho support.