Added a conceptual sketch, and filled out the readme file #14
Conversation
README.md
Outdated
| * Subscriptions (i.e. receiving notifications when resources are updated). | ||
| * Uploading/downloading/removing files. | ||
| * Checking controller state (e.g. motors on/off, auto/manual mode and RAPID execution running/stopped). | ||
| * And more. |
There was a problem hiding this comment.
This seems a bit vague: the first sentence in this section states "several of the RWS services, but not all of them". Then this item in the list says "and more".
Ideally we should be explicit about what is supported. Would it be possible to include an exhaustive list?
There was a problem hiding this comment.
Yeah, that is true, I will clarify this.
README.md
Outdated
|
|
||
| ### Recommendations | ||
|
|
||
| * The current version of this library is recommended to be used with **RobotWare 6.06.01**. |
There was a problem hiding this comment.
The RWS functionality doesn't suffer from the same incompatibilities as the EGM one, right?
There was a problem hiding this comment.
No, it is just that some of the implemented methods will not work with earlier versions (e.g. since some of the RWS services don't exist there). Currently it is 6.06.01 that I have primarily verified against, so that is why I recommend it.
|
Could you also address #5 with this update to the readme? |
|
SVG renders strangely for me. Was there something wrong with the PNG? Edit: looks like the bounding box of the svg is not correctly set (lots of unneeded empty space around the figure). |
|
I think I have addressed all the current remarks. Regarding the sketch (you were too fast! :)), I felt that the png file was a bit pixelated so I tried with svg instead. Also, the drawing program I used auto removed the empty space for png but not for svg, which I noticed after I pushed the changes. |
|
Nice update again @jontje 👍 |
As per title.