Removed reference from input argument

[jontje]

Fix for a bug that was accidently introduced in PR #58.

The bug caused nestled RAPID records to be wrongly parsed.

[gavanderhoorn]

Could you provide some more insight into what went wrong and how the change introduced by #58 caused it?

Also: we need to add (unit) tests here. Good ones would catch such regressions.

[jontje]

Thanks for the review @gavanderhoorn 👍

Could you provide some more insight into what went wrong and how the change introduced by #58 caused it?

The method affected by this PR counts the number of times a character occur in a string, and it does that by:

1. Use std::string::find_first_of.
2. Removing the character.
3. Repeat from 1. until reaching the end of the string.

Step 2. caused the method to alter the original string when a reference was used for the argument.

Example of the bug:

• Simple RAPID record: [1,2,3] --> became 1,2,3 --> could still be parsed correctly.
• Nestled RAPID record: [1,2,3,[4,5,6]] --> became 1,2,3,4,5,6 --> could not be parsed correctly.

Also: we need to add (unit) tests here. Good ones would catch such regressions.

Yes, that would be great. I have expanded my functional tests with a case to check this, but I only run them ad hoc.

[gavanderhoorn]

Tracking tests in #77.