Added visualization tool that allows user to toggle visibility of applie… #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d tool path and mesh modifiers
marip8
requested changes
Dec 11, 2023
noether_tpp/include/noether_tpp/core/tool_path_planner_pipeline.h
Outdated
Show resolved
Hide resolved
…catenate method still needs to be investigated.
…ead of raw pointers for internal objects
marip8
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
@DavidSpielman please confirm that the latest changes still work correctly with your test case. Once that is confirmed, this should be ready to merge
|
@marip8 I have reviewed the changes, and they still work with the test case I used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d tool path and mesh modifiers
I created a mesh modifier that splits a given mesh with an origin at (0,0,0) in half by filtering the points on one side of the y axis and saving the inlier and outlier meshes of this operation into one combined mesh.
Originally, I used the concatenate() method from pcl::PolygonMesh to visualize the modified meshes into one combined mesh, but this resulted in a broken combined mesh. I verified that the inlier and outlier meshes from my mesh modifier were valid, and I confirmed that they could be concatenated into a single mesh in Open3D. The combined mesh was then manually created from the given input meshes instead of using the concatenate() method. How the concatenate
method combines meshes will require further investigation.
Below are images showing the functionality of the visualization tool. The checkboxes that are ticked show the components that they control the visibility of.