Make NoOpEvaluator return 1.0 (#71)

* Make NoOpEvaluator return 1.0 * Fix pytest
ros-industrial · Apr 29, 2024 · d89ddaf · d89ddaf
1 parent 0aa9e6f
commit d89ddaf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/scripts/test_reach.py b/scripts/test_reach.py
@@ -156,9 +156,9 @@ def test_run_reach_study_mixed(self):
 
         results = db.calculateResults()
         logger.printResults(results)
-        self.assertAlmostEqual(results.total_pose_score, 0.0)
+        self.assertAlmostEqual(results.total_pose_score, 100.0)
         self.assertAlmostEqual(results.reach_percentage, 100.0)
-        self.assertAlmostEqual(results.norm_total_pose_score, 0.0)
+        self.assertAlmostEqual(results.norm_total_pose_score, 100.0)
 
         display.showEnvironment()
 

diff --git a/src/plugins/no_op.cpp b/src/plugins/no_op.cpp
@@ -4,7 +4,7 @@ namespace reach
 {
 double NoOpEvaluator::calculateScore(const std::map<std::string, double>&) const
 {
-  return 0.0;
+  return 1.0;
 }
 
 Evaluator::ConstPtr NoOpEvaluatorFactory::create(const YAML::Node&) const