Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for simulation interfaces #1

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
cmake_minimum_required(VERSION 3.8)
project(simulation_interfaces)

if(NOT CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
endif()
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic)
endif()

find_package(ament_cmake REQUIRED)
find_package(builtin_interfaces REQUIRED)
find_package(geometry_msgs REQUIRED)
find_package(rosidl_default_generators REQUIRED)
find_package(std_msgs REQUIRED)

set(msg_files
"msg/Entity.msg"
"msg/EntityState.msg"
"msg/EntityWithState.msg"
"msg/Spawnable.msg"
"msg/SpawnableBounds.msg"
"msg/SpawnPose.msg"
)

set(srv_files
"srv/DeleteEntity.srv"
"srv/GetEntities.srv"
"srv/GetEntityState.srv"
"srv/GetSimulatorFeatures.srv"
"srv/GetSpawnables.srv"
"srv/GetSpawnPoses.srv"
"srv/ResetSimulation.srv"
"srv/SetEntityState.srv"
"srv/SetSimulationPaused.srv"
"srv/SpawnEntity.srv"
"srv/StepSimulation.srv"
)

set(action_files
"action/MultiStepSimulation.action"
)

rosidl_generate_interfaces(${PROJECT_NAME}
${msg_files}
${srv_files}
${action_files}
DEPENDENCIES builtin_interfaces std_msgs geometry_msgs
ADD_LINTER_TESTS
)

ament_export_dependencies(rosidl_default_runtime)

ament_package()
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
# simulation_interfaces
Standard interfaces for interacting with simulators from ROS 2
# Simulation Interfaces

Standard ROS 2 interfaces for interacting with simulators.
Messages and services are documented in their respective files.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
11 changes: 11 additions & 0 deletions action/MultiStepSimulation.action
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Assuming the simulation is paused, simulate a finite number of steps and return to paused state.
# The action returns feedback after each complete step.
# For a service alternative, see StepSimulation, which often makes more sense when doing a single step (steps = 1).

uint16 steps # Action goal: step through the simulation loop this many times.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
---
bool success # Return true if stepping is supported and was successful.
string status_message # Additional comments or error status.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
# Calling with simulation not paused will return failure and an appropriate message.
---
uint16 completed_steps # Action feedback: number of completed steps in this action so far.
4 changes: 4 additions & 0 deletions msg/Entity.msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Entity name and description

string name # Scoped name of the entity. It must be unique (including namespace).
string description # Optional: additional information about entity.
8 changes: 8 additions & 0 deletions msg/EntityState.msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Entity current pose and twist
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved

std_msgs/Header header # Frame and timestamp for pose and twist. Empty frame defaults to world.
geometry_msgs/Pose pose # Pose in reference frame, ground truth.
geometry_msgs/Twist twist # Ground truth body twist in the reference frame.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for ground truth twist, the body twist has to be expressed in the world frame. In the convention mentioned in ros2/common_interfaces#240, we'd have:

body_frame_id = "frame_name_of_entity" 
header.frame_id = "world"
reference_frame_id = "world"

@tfoote can you confirm? When both header.frame_id and reference_frame_id are "world", it looks like a spatial twist, but that's not what we need here. Maybe we need to clarify that the VelocityStamped message always represents body twists, but expressed in the frame specified by reference_frame_id.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azeey @tfoote once you confirm, I would welcome a suggestion or an extra context to make sure I understand and apply this correctly

# It is observed and defined in the local coordinates system of the body.
# See https://github.com/ros2/common_interfaces/pull/240 for conventions.
geometry_msgs/Accel acceleration # Linear and angular acceleration ground truth, following the same convention.
4 changes: 4 additions & 0 deletions msg/EntityWithState.msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Entity with its current ground truth state

Entity entity # Entity name and description
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
EntityState state # Entity current state
7 changes: 7 additions & 0 deletions msg/SpawnPose.msg
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# A named spawn pose

string pose_name # Name of a spawn pose. It does not need to be unique.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
string pose_description # Description for the user, e.g. "near the charging station".
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
geometry_msgs/Pose pose # Spawn pose, which can be used with SpawnEntity.srv.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved

SpawnableBounds spawn_bounds # Optional spawn area bounds.
5 changes: 5 additions & 0 deletions msg/Spawnable.msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Robot or other object which can be spawned in simulation runtime.

string uri # URI which will be accepted by SpawnEntity service.
string description # Optional description for the user, e.g. "robot X with sensors A,B,C".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to include an optional source field here to indicate if the simulator should limit itself to spawnables available locally or should include remote sources as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you suggest semantics of such a field in more detail?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this field makes more sense as an input for the GetSpawnables service. I'd imagine a simulator can have multiple sources of spawnables:

  1. Local disk (other ROS packages, files placed in directories where the simulator expects, etc.)
  2. Remote (Files from a remote service, such as Fuel)

Both of these sources may have subcategorizations to limit the number spawnables returned as well the depth of searching required.

We could make the field an array of strings and let the simulator define what the values are, or we can make them enums if there is broad agreement on what the enums should be. I lean toward an array of strings.

SpawnableBounds spawn_bounds # Optional spawn area bounds which fully encompass this object.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
11 changes: 11 additions & 0 deletions msg/SpawnableBounds.msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Bounds for spawning an entity, e.g. to avoid spawning with other object overlap.
# Spawn pose might be valid for a small object, but not suitable for a large one, or a differently shaped one.
# These limits are relative to spawn pose or entity's top link transform, following ROS rep-103 conventions.

# By default, both fields are zero vectors which means that spawning is unbounded.
# Otherwise, the fields are expected to form a valid box containing the (0,0,0) point which is the spawn position.
# You should check whether the entity simulation model fits within the bounds before spawning, to avoid overlaps and
# unstable behavior.

geometry_msgs/Vector3 upper_right # Optional: the upper right corner of the spawn box.
geometry_msgs/Vector3 lower_left # Optional: the lower left corner of the spawn box.
28 changes: 28 additions & 0 deletions package.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>simulation_interfaces</name>
<version>1.0.0</version>
<description>A package containing simulation interfaces including messages and services</description>
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
<maintainer email="adam.dabrowski@robotec.ai">Adam Dabrowski</maintainer>
<license>Apache License 2.0</license>
<url type="repository">https://github.com/ros-simulation/simulation-interfaces</url>
<author email="adam.dabrowski@robotec.ai">Adam Dabrowski</author>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>rosidl_default_generators</buildtool_depend>

<depend>builtin_interfaces</depend>
<depend>geometry_msgs</depend>
<depend>std_msgs</depend>

<exec_depend>rosidl_default_runtime</exec_depend>

<test_depend>ament_lint_common</test_depend>

<member_of_group>rosidl_interface_packages</member_of_group>

<export>
<build_type>ament_cmake</build_type>
</export>
</package>
8 changes: 8 additions & 0 deletions srv/DeleteEntity.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Remove an entity (a robot, other object) by unique name from the simulation

string name # Unique name with a namespace, as returned by SpawnEntity or GetEntities.

---

bool success # return true if deleted successfully.
string status_message # On failure, a user-friendly error message.
12 changes: 12 additions & 0 deletions srv/GetEntities.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Get objects in the scene which can be interacted, e.g. with using SetEntityState.

string filter # Optional, defaults to empty. Return entities with matching names.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
# Entity names are matched with the filter regular expression.
# An empty filter will result in all entities being returned.
Comment on lines +3 to +5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this, another cool idea could be to tag Entitys with some category label, e.g., "robot" vs. "object" vs. "furniture", etc.

This way you can not only filter by name, but also by category -- of course, every simulator interface implementer would tag their own entities with relevant categories.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but it seems to be introducing a new concept of entity tags. Which needs to be reflected in the Entity.msg and other interfaces. Perhaps this could be an extension? This sounds much like a synthetic data feature.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sea-bass what do you think? Would you like to include labels in the PR still?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be useful to label entities with categories (as you said in the Entity.msg), and then be able to retrieve them by categories.

Should it be done with this initial PR? Not necessarily, but I'd appreciate at least a separate gitissue tracking this request. I certainly use these mechanisms all the time in my simulator.


---

EntityWithState[] entities # All entities with their states, matching the filter.

bool success # Return true if successful.
string status_message # Additional comments or error status.
10 changes: 10 additions & 0 deletions srv/GetEntityState.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Get state of an object. Valid objects are on the list returned by GetEntities.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved

string name # Unique name as returned by GetEntities / SpawnEntity.

---

EntityState entity_state # Entity ground truth state.

bool success # Return true if successful.
string status_message # Additional comments or error status.
32 changes: 32 additions & 0 deletions srv/GetSimulatorFeatures.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Get a list of features supported by the simulator.
# Simulators adhering to the standard need to implement at least this interface.

---

adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
uint8 SPAWNING = 0 # Supports spawn interface (SpawnEntity).
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
uint8 DELETING = 1 # Supports deleting entities (DeleteEntity).
uint8 SPAWN_POSES = 2 # Supports predefined spawn poses (GetSpawnPoses).
uint8 SPAWN_BOUNDS = 3 # Supports spawn bounds (SpawnableBounds).
uint8 SPAWN_FORMAT_SDF = 4 # Supports spawning from SDFormat specified in the uri field of SpawnEntity.
uint8 SPAWN_FORMAT_URDF = 5
uint8 SPAWN_FORMAT_USD = 6
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
uint8 SPAWN_FORMAT_NATIVE = 7 # Supports spawning from prefab / other simulator native format.

uint8 ENTITY_STATE_LISTING = 8 # Supports GetEntityState interface.
uint8 ENTITY_STATE_SETTING = 9 # Supports SetEntityState interface.

uint8 SIMULATION_RESET = 10 # Supports one or more ways to reset the simulation through ResetSimulation.
uint8 SIMULATION_RESET_TIME = 11 # Supports TIME flag for resetting.
uint8 SIMULATION_RESET_OBJECTS = 12 # Supports OBJECTS flag for resetting.
uint8 SIMULATION_RESET_SPAWNED = 13 # Supports SPAWNED flag for resetting.

uint8 SIMULATION_PAUSE = 14 # Supports SetSimulationPaused interface
uint8 STEP_SIMULATION_SINGLE = 15 # Supports single stepping through simulation with StepSimulation interface.
uint8 STEP_SIMULATION_MULTIPLE = 16 # Supports multi-stepping through simulation, either through StepSimulation.
# service or through MultiStepSimulation action.
uint8 STEP_SIMULATION_ACTION = 17 # Supports MultiStepSimulation action interface.


uint8[] features # A list of simulation features as specified by the list above.
string custom_info # Optional: additional information for the caller, which could point to documentation,
# version compatibility and other useful meta information.
10 changes: 10 additions & 0 deletions srv/GetSpawnPoses.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Get predefined spawn poses which is convenient to avoid spawning in invalid spaces.
# This is an optional simulation feature: check status_message if you receive an empty spawn_poses vector,
# to determine whether this feature is not supported by your simulator, or spawn poses are simply not defined.

adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
---

SpawnPose[] spawn_poses # A list of predefined spawn_poses, which may be empty.

bool success # Return true if successful.
string status_message # Additional comments or error status.
9 changes: 9 additions & 0 deletions srv/GetSpawnables.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Return a list of resources which are valid as SpawnEntity uri fields (e.g. visible to or registered in simulator).
# This interface is an optional extension and might not be implemented by your simulator, check the status_message.

adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
---

Spawnable[] spawnables # Spawnable objects with URI and additional information.

bool success # Return true if successful.
string status_message # Additional comments or error status.
15 changes: 15 additions & 0 deletions srv/ResetSimulation.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Reset the simulation to the start, including the entire scene and the simulation time.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
# Objects that were dynamically spawned are de-spawned.

uint8 DEFAULT=0 # same as ALL.
uint8 TIME=1 # Reset simulation time to start.
uint8 OBJECTS=2 # Reset all poses and velocities.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
uint8 SPAWNED=4 # De-spawns all spawned entities.
uint8 ALL=7 # Fully resets simulation to the start, as if it was closed and launched again.

uint8 reset_scope # Scope of the reset. Note that simulators might only support some types of resets.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved

---

bool success # Return true if successful.
string status_message # Additional comments or error status, such as what reset types are supported.
9 changes: 9 additions & 0 deletions srv/SetEntityState.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Set a state of an object, which will result in an instant change in its pose and/or twist.

string name # Unique name as returned by GetEntities or SpawnEntity.
EntityState state # New state to set immediately. The timestamp in header is ignored.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved

---

bool success # Return true if successful.
string status_message # Additional comments or error status.
9 changes: 9 additions & 0 deletions srv/SetSimulationPaused.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Pauses or unpauses the simulation
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved

bool pause # If true, sets simulation state to paused, otherwise sets it to running.
# If already in target state, nothing happens but status_message informs about it.

---

bool success # Return true if pausing / resuming was successful.
string status_message # Additional comments or error status.
19 changes: 19 additions & 0 deletions srv/SpawnEntity.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Spawn an entity (a robot, other object) by name or URI
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved

string name # Suggest a name to give to the spawned entity. If left empty, it will be generated.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
# Due to requirement for name uniqueness and the namespace, check the status_message
# to get an actual unique name to use for further queries.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
string uri # Resource such as SDF or URDF file, or in native format such as prefab.
# Valid URIs can be determined by calling GetSpawnables first,
# if the feature is supported by your simulator.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
string entity_namespace # Spawn robot or another object with all its interfaces under this namespace.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
string reference_frame # Optional initial pose reference frame. Defaults to global "world" frame.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
# This ROS frame must be known to the simulator, e.g. of an object spawned earlier.
geometry_msgs/Pose initial_pose # Initial entity pose. Simulators should spawn the entity with its top-level link
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
# transform matching this pose.

---

bool success # Return true if spawned successfully.
string status_message # On failure, a user-friendly error message.
string unique_name # Spawned entity full name (with namespace).
11 changes: 11 additions & 0 deletions srv/StepSimulation.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# If simulation is paused, take N steps and pause it back. The service only returns once stepping is complete, which
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved
# might take considerable time.
# There is an alternative in MultiStepSimulation action, which is worth considering for a multi-step interface.

uint16 steps # Step through the simulation loop this many times.
adamdbrw marked this conversation as resolved.
Show resolved Hide resolved

---

bool success # Return true if stepping is supported and was successful.
string status_message # Additional comments or error status.
# Calling with simulation not paused will return failure and an appropriate message.