-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reference to the new source entry requirement for ros2-gbp repository creation. #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitory creation. As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created. This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created.
clalancette
requested changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change to make it flow a bit better, then I'm happy with this.
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for iterating!
clalancette
added
the
backport-all
backport at reviewers discretion; from rolling to all versions
label
Sep 9, 2022
delete-merged-branch
bot
deleted the
nuclearsandwich/ros2-gbp-process
branch
September 9, 2022 20:35
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
…sitory creation. (#2992) * Add a reference to the new source entry requirement for ros2-gbp repository creation. As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created. This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created. Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit ecdfd5f)
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
…sitory creation. (#2992) * Add a reference to the new source entry requirement for ros2-gbp repository creation. As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created. This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created. Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit ecdfd5f)
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
…sitory creation. (#2992) * Add a reference to the new source entry requirement for ros2-gbp repository creation. As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created. This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created. Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit ecdfd5f)
clalancette
pushed a commit
that referenced
this pull request
Sep 9, 2022
…sitory creation. (#2992) (#3011) * Add a reference to the new source entry requirement for ros2-gbp repository creation. As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created. This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created. Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit ecdfd5f) Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Sep 9, 2022
…sitory creation. (#2992) (#3012) * Add a reference to the new source entry requirement for ros2-gbp repository creation. As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created. This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created. Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit ecdfd5f) Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Sep 9, 2022
…sitory creation. (#2992) (#3013) * Add a reference to the new source entry requirement for ros2-gbp repository creation. As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created. This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created. Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit ecdfd5f) Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created.
This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created.
Connects to ros2-gbp/ros2-gbp-github-org#106