Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nvidia-ROS2-Projects.rst #3977

Merged

Conversation

AsawareeBhide
Copy link

Updates for Isaac ROS 2.0.0

@@ -5,22 +5,28 @@ NVIDIA provides packages for the development of AI applications for robotics.

ISAAC ROS Projects
------------------
* `Pre-built ROS 2 Humble support <https://nvidia-isaac-ros.github.io/getting_started/isaac_ros_buildfarm_cdn.html>`__: Pre-built Debian packages for ROS 2 Humble on Ubuntu 20.04 for Jetson and other aarch64 platforms from the NVIDIA build farm.
* `CUDA with NITROS <https://nvidia-isaac-ros.github.io/concepts/nitros/cuda_with_nitros.html>`__: This helps users develop their own CUDA enabled nodes that work with NITROS, the Isaac ROS implementation of type adaptation & type negotiation which enables accelerated computing in ROS 2.
* `Isaac ROS NITROS Bridge <https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_nitros_bridge>`__: NITROS bridge for optimized integration of Isaac ROS packages with existing ROS 1 applications. This provides accelerated computing in Noetic (and other ROS versions) with >2x speed up compared to a traditional ROS bridge.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also supported with Iron? if not, it would be better to specify that it supports Humble?

Suggested change
* `Isaac ROS NITROS Bridge <https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_nitros_bridge>`__: NITROS bridge for optimized integration of Isaac ROS packages with existing ROS 1 applications. This provides accelerated computing in Noetic (and other ROS versions) with >2x speed up compared to a traditional ROS bridge.
* `Isaac ROS NITROS Bridge <https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_nitros_bridge>`__: NITROS bridge for optimized integration of Isaac ROS packages with existing ROS 1 applications. This provides accelerated computing in Noetic and Humble with >2x speed up compared to a traditional ROS bridge.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac ROS containers are all Humble and the NITROS bridge supports integration of Noetic and other ROS 1 versions with Humble.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the ROS 2 documentation, I don't think we should link to ROS 1 packages or encourage them (unless it is bridging from ROS 1 to ROS 2). So I'd say let's remove this line, or edit it to remove the reference to Noetic.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does in fact bridge from ROS 1 to ROS 2. The project includes 2 converter nodes (1 to be used on the ROS 1 side and the other to be used on the ROS 2 side). I could rephrase the sentence to - "Use this to bridge your ROS applications to ROS 2 for accelerated computing with >2x speed up compared to using a traditional ROS bridge". Would that be better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Use this to bridge your ROS applications to ROS 2 for accelerated computing with >2x speed up compared to using a traditional ROS bridge". Would that be better?

Yep, that sounds great!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I made the change.

@@ -5,22 +5,28 @@ NVIDIA provides packages for the development of AI applications for robotics.

ISAAC ROS Projects
------------------
* `Pre-built ROS 2 Humble support <https://nvidia-isaac-ros.github.io/getting_started/isaac_ros_buildfarm_cdn.html>`__: Pre-built Debian packages for ROS 2 Humble on Ubuntu 20.04 for Jetson and other aarch64 platforms from the NVIDIA build farm.
* `CUDA with NITROS <https://nvidia-isaac-ros.github.io/concepts/nitros/cuda_with_nitros.html>`__: This helps users develop their own CUDA enabled nodes that work with NITROS, the Isaac ROS implementation of type adaptation & type negotiation which enables accelerated computing in ROS 2.
* `Isaac ROS NITROS Bridge <https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_nitros_bridge>`__: NITROS bridge for optimized integration of Isaac ROS packages with existing ROS 1 applications. This provides accelerated computing in Noetic (and other ROS versions) with >2x speed up compared to a traditional ROS bridge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the ROS 2 documentation, I don't think we should link to ROS 1 packages or encourage them (unless it is bridging from ROS 1 to ROS 2). So I'd say let's remove this line, or edit it to remove the reference to Noetic.

@clalancette clalancette merged commit a4b5d21 into ros2:humble Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants