Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bag play progress bar review from Michael Orlov #1902

Draft
wants to merge 13 commits into
base: rolling
Choose a base branch
from
Draft

Bag play progress bar review from Michael Orlov #1902

wants to merge 13 commits into from

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov MichaelOrlov commented Jan 26, 2025 •
edited
Loading

@MichaelOrlov
Squashed commit of the following:
c4a7231 
commit 913de31
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Sun Dec 8 18:27:06 2024 +0100

    stubgen

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 8625164
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Sun Dec 8 17:14:26 2024 +0100

    add custom space between playback output and progress bar

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 6a47a7f
Merge: fb464b0 8f1527e
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Sun Dec 8 11:14:01 2024 +0100

    Merge branch 'rolling' into nicolaloi/bag-play-progress-bar

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit fb464b0
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Fri Dec 6 22:40:45 2024 +0100

    comments

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 19df032
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Fri Dec 6 22:28:51 2024 +0100

    change progress bar string, change 'frequency' terms to 'update rate'

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 47dff3d
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Thu Dec 5 22:06:34 2024 +0000

    Progress bar with nanosecond precision and shorter length

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 0ef3f26
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Wed Dec 4 22:35:10 2024 +0000

    comments

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 6051e6c
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Mon Dec 2 23:29:10 2024 +0000

    some updates after merge with rolling

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 372b8a2
Merge: 0c99597 125db50
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Mon Dec 2 23:35:09 2024 +0100

    Merge branch 'rolling' into nicolaloi/bag-play-progress-bar

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 0c99597
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Mon Nov 18 21:53:16 2024 +0100

    add burst status, reduce cout setprecision

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit bac4e9f
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Sun Nov 17 21:05:43 2024 +0100

    update to avoid synchronization issues

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 9cdf5ad
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Sun Nov 10 22:59:27 2024 +0100

    update default rate

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 43fa0f8
Author: Nicola Loi <nicloi@student.ethz.ch>
Date:   Mon Oct 28 23:00:06 2024 +0000

    Code review

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit a00bdc4
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Thu Oct 24 00:06:25 2024 +0200

    convert to template

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 4ba1a8c
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Mon Oct 21 00:49:08 2024 +0200

    remove new progress bar class, integrate functionality in PlayerImpl

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 2cb732d
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Wed Oct 16 00:21:08 2024 +0200

    clean #include

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

commit 616df0d
Author: Nicola Loi <nicolaloi@outlook.com>
Date:   Tue Oct 15 22:34:34 2024 +0200

    Start adding progress-bar for ros2 bag play

    Signed-off-by: Nicola Loi <nicolaloi@outlook.com>

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Change type of progress_bar_update_rate to int32_t
347c461 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Remove "in_burst_mode" from play_next() method
7dc4001 
- Rationale: We will update progress bar with check rate from main
playback loop even in burst mode.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Move progress bar to a separate PlayerProgressBar class
dea12f5 
- Rationale: To adhere single responsibility principle

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Move PlayerStatus inside PlayerProgressBar
00fbad5 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Move PlayerProgressBar class to a separate h(c)pp files
6abbbe7 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Use Pimpl design pattern for PlayerProgressBar class
cd4b0f0 
- Also added appropriate Doxygen comments for public API

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Replace logger and std::cout with reference to the std::ostream
ec3cdee 
- Rationale: To be able to redirect progress bar output to the
 std::ostringstream in unit tests.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Use std::stringstream and rdbuf() to avoid extra data copy to string
7799aaa 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Change type of the progress_bar_separation_lines to the uint32_t
cb19562 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Simplify logic by using update period in milliseconds
a13ca0c 
- The progress_bar_update_period_ms_ equal to 0 means update always.
- Also use integer arithmetic for the sake of performance.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Regenerate pyi stub files
f09eaea 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov
Add test_player_progress_bar.cpp with TODOs
42e5134 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaelOrlov