Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 18c support #208

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Improve 18c support #208

wants to merge 20 commits into from

Conversation

joschug
Copy link

@joschug joschug commented Oct 27, 2021

This fixes #204, #207 and probably #200.

  • Resolve type synonyms
  • Support cross-schema type references
  • Added support for package types declared as %ROWTYPE
  • Added support for %ROWTYPE as procedure parameter
  • Exclude hidden columns from table types
  • Remap TIMESTAMP(n) WITH LOCAL TIMEZONE to TIMESTAMP WITH LOCAL TIMEZONE
  • Remap PL/SQL PLS/BINARY INTEGER to PLS_INTEGER/BINARY_INTEGER

joschug added 20 commits October 11, 2021 13:49
@joschug
Try to resolve package synonyms like utl_file.file_type
513ea0a
@joschug
Field definitions do not necessarily have to come from the current sc…
4c5959d 
…hema; the type owner should take precedence
@joschug
Split lookup against all_objects into second query; alleviates the po…
38bd95c 
…or performance
@joschug
Field definitions do not necessarily have to come from the current sc…
1f328bf 
…hema; the type owner should take precedence
@joschug
Try to resolve type synonyms - also for elements and table/view types
6befbcc
@joschug
Allow variable declarations that do not end with a semicolon
244bcd6
@joschug
18c: Resolve %ROWTYPE within an element
00ebb3d
@joschug
Merge branch '18c_allow_field_definitions_from_other_schemas' into dev
631aa40
@joschug
Merge branch '18c_public_plsql_records' into dev
afab0c1 
# Conflicts:
#	lib/plsql/procedure.rb
@joschug
Merge branch '18c_variables_without_semicolon_at_the_end_of_the_line'…
700b418 
… into dev
@joschug
Merge branch '18c_resolve_element_rowtype' into dev
907f516
@joschug
Exclude hidden columns
de8b2e5
@joschug
Fix "no implicit conversion of Time into String" if column data type is
54429b5 
"timestamp(6) with local timezone"; before 18c, this was represented as
"timestamp with local timezone"
@joschug
18c: Resolve %ROWTYPE within an element
d0d5beb
@joschug
Merge branch '18c_resolve_element_rowtype' into dev
dfcdc33 
# Conflicts:
#	lib/plsql/procedure.rb
@joschug
Make char length determination consistent
2eedc94
@joschug
Try to fix nested types - type declared inside a package, referencing…
403ef6a 
… a schema-level table type
@joschug
Map new PL/SQL types to old types
cbdc13f
@joschug
Remove debug output
0409a09
@joschug
Merge branch '18c_public_plsql_records' into dev
89e4af9
@joschug joschug changed the title Dev Improve 18c support Oct 27, 2021
This was referenced Oct 27, 2021
Closed
Closed
Open
@yahonda
Copy link
Collaborator

yahonda commented May 12, 2023

Could you please break this pull request into smaller pieces?

@Faq
Copy link

Faq commented Aug 23, 2024 •
edited
Loading

Using this for a year with Rails 5.2 and 18c, now upgraded Rails to v7.0, still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ruby-plsql 0.8.0: Procedure with parameters referencing system packages fails
3 participants
@joschug @yahonda @Faq