Fix type of PO.Item

[kirillku]

Currently, it's not possible to access Item type. The proposed change should fix the issue.

declare class Item {
    public msgid: string;
    public msgctxt?: string;
    public references: string[];
    public msgid_plural?: string;
    public msgstr: string[];
    public comments: string[];
    public extractedComments: string[];
    public flags: Record<string, boolean | undefined>;
    private nplurals: number;
    private obsolete: boolean;

    public toString(): string;
}

// This is how it's done currently
declare class CurrentPO { 
    public static Item: typeof Item; 
}

// Any of those give warnings or provide a wrong type
declare const currentItem1: CurrentPO.Item
declare const currentItem2: typeof CurrentPO.Item
currentItem2.msgid
declare const currentItem3: InstanceType<CurrentPO.Item>

// This way it will be possible to get Item type without any ts warnings
declare class UpdatedPO { 
    public static Item: Item; 
}

// Works
declare const updatedItem: typeof UpdatedPO.Item
updatedItem.msgid

ts playground

Related to #36

[septs]

// works
const item = new CurrentPO.Item()

// not works
// This expression is not constructable.
//  Type 'Item' has no construct signatures.(2351)
const updatedItem = new UpdatedPO.Item();

[septs]

@rubenv The PR, Will affect to new PO.Item()

[rubenv]

Oh wait I read this wrong. Reverted the merge!

[rubenv]

So TS definitions are not my area of expertise. Just let me know when it's actually OK and I'll do the right thing :-)

[kirillku]

@rubenv what do you think about adding named imports then?

[septs]

@kirillku switch to esmodule is the best choice

[septs]

OR using namespace

declare namespace PO {
    export type ItemType = Item
}

const item: PO.ItemType = new PO.Item()

This is the only solution currently available

CC @kirillku

[kirillku]

@septs I found a way how to to it without making any changes to lib types. Looks quite hacky through.

type ItemType = InstanceType<typeof PO.Item>

ts playground

[septs]

@kirillku bingo