Merge pull request #487 from Earlopain/missing-restrict-on-send

Add missing `RESTRICT_ON_SEND` for two cops
rubocop · Jan 25, 2025 · 2f8ae50 · 2f8ae50
2 parents b83ff1e + 664b6b0
commit 2f8ae50
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/rubocop/cop/performance/chain_array_allocation.rb b/lib/rubocop/cop/performance/chain_array_allocation.rb
@@ -45,6 +45,8 @@ class ChainArrayAllocation < Base
 
         RETURNS_NEW_ARRAY = (ALWAYS_RETURNS_NEW_ARRAY + RETURNS_NEW_ARRAY_WHEN_NO_BLOCK).freeze
 
+        RESTRICT_ON_SEND = RETURNS_NEW_ARRAY
+
         MSG = 'Use unchained `%<method>s` and `%<second_method>s!` ' \
               '(followed by `return array` if required) instead of chaining ' \
               '`%<method>s...%<second_method>s`.'

diff --git a/lib/rubocop/cop/performance/collection_literal_in_loop.rb b/lib/rubocop/cop/performance/collection_literal_in_loop.rb
@@ -65,6 +65,8 @@ class CollectionLiteralInLoop < Base
 
         HASH_METHODS = (ENUMERABLE_METHOD_NAMES | NONMUTATING_HASH_METHODS).to_set.freeze
 
+        RESTRICT_ON_SEND = ARRAY_METHODS + HASH_METHODS
+
         def_node_matcher :kernel_loop?, <<~PATTERN
           (block
             (send {nil? (const nil? :Kernel)} :loop)