Skip to content

Commit

Permalink
Merge pull request #1251 from pocke/Ignore__set__library_on_loading
Browse files Browse the repository at this point in the history
Ignore `set` library on loading
  • Loading branch information
soutaro authored Feb 27, 2023
2 parents 215adf6 + 64b5eaa commit 88f4f55
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
11 changes: 5 additions & 6 deletions lib/rbs/collection/config/lockfile_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,11 @@ def generate
private def assign_stdlib(name:, from_gem:)
return if lockfile.gems.key?(name)

if name == 'rubygems'
if from_gem
RBS.logger.warn "`rubygems` has been moved to core library, so it is always loaded. Remove explicit loading `rubygems` from `#{from_gem}`"
else
RBS.logger.warn '`rubygems` has been moved to core library, so it is always loaded. Remove explicit loading `rubygems`'
end
case name
when 'rubygems', 'set'
msg = "`#{name}` has been moved to core library, so it is always loaded. Remove explicit loading `#{name}`"
msg << " from `#{from_gem}`" if from_gem
RBS.logger.warn msg

return
end
Expand Down
1 change: 0 additions & 1 deletion sig/manifest.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
dependencies:
- name: logger
- name: set
- name: pathname
- name: json
- name: optparse
Expand Down

0 comments on commit 88f4f55

Please sign in to comment.