Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully able to run tests locally #5366

Closed

Conversation

jacklynhma
Copy link
Contributor

How to replicate bug:

  • Run bin/rails test:all locally
  • You will see the below error message
Screenshot 2024-12-26 at 15 34 23

I introduce this bug accidentally in this PR https://github.com/rubygems/rubygems.org/pull/5250/files

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (96cba03) to head (34b18b7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5366      +/-   ##
==========================================
- Coverage   97.14%   94.37%   -2.77%     
==========================================
  Files         458      458              
  Lines        9584     9643      +59     
==========================================
- Hits         9310     9101     -209     
- Misses        274      542     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi
Copy link
Member

simi commented Dec 27, 2024

How possible test passed on that PR?

@jacklynhma
Copy link
Contributor Author

jacklynhma commented Dec 27, 2024

How possible test passed on that PR?

@simi Great question! Thanks for calling that out. I dug into rubygem.org's builds and it looks like the reason why the build passed on this PR is that the test builds run each test folder individually (ie: the system folder runs bin/rails test:system) AND the test files that had the same name were in different test folders ( one was in the systemfolder and the other wasintegration`.

Screenshot 2024-12-27 at 16 29 54

That is why this bug was only caught if the bin/rails test:all was run.

@colby-swandale
Copy link
Member

The fix is appreciated, but this is actually a duplicate of #5338

@jacklynhma
Copy link
Contributor Author

@colby-swandale opps I missed that PR. Sorry about the bug. I will close this PR.

@jacklynhma jacklynhma closed this Dec 28, 2024
@jacklynhma jacklynhma deleted the fix-bug-to-run-tests-locally branch December 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants