Update to ruby 3.4.1 #5382
Merged
Update to ruby 3.4.1 #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/update-to-ruby-3.4.1
branch
3 times, most recently
from
759d111 to
ff2be24
Compare
Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
segiddins
force-pushed
the
segiddins/update-to-ruby-3.4.1
branch
from
94d84d7 to
33ae713
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5382 +/- ##
==========================================
- Coverage 97.14% 97.12% -0.02%
==========================================
Files 458 458
Lines 9584 9588 +4
==========================================
+ Hits 9310 9312 +2
- Misses 274 276 +2 ☔ View full report in Codecov by Sentry. |
simi
approved these changes
Jan 11, 2025
|
@segiddins I was looking into the codecov report, since it reported unused lines after the upgrade. Do you think that's ok/mistake of codecov? |
|
The comment said everything was covered? |
|
Yes, there are two checks. One passed, second complained about https://app.codecov.io/gh/rubygems/rubygems.org/pull/5382/indirect-changes drop in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samuel Giddins segiddins@segiddins.me