-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat notion reader add db content #17393
Draft
HenryRoutson
wants to merge
31
commits into
run-llama:main
Choose a base branch
from
HenryRoutson:feat_notion_reader_add_db_content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat notion reader add db content #17393
HenryRoutson
wants to merge
31
commits into
run-llama:main
from
HenryRoutson:feat_notion_reader_add_db_content
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Dec 30, 2024
if this is likely to get merged just let me know |
@HenryRoutson if it works, it'll get merged -- net new features are nice :) |
Thanks! Just a heads up i am still working on it. |
Converting to draft since its still in progress (afaik) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unfinished currently, i am still working on this currently
putting this up to make sure no one does the same thing
and for feedback
working on fixing a number of bugs including
And adding features
And most importantly
improved code quality,
with logic related to pagination and requests becoming more encapsulated
Fixes # (issue)
Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
i can add unit tests in future,
but for now i am using a large notion database as a realistic testing environment
Suggested Checklist:
make format; make lint
to appease the lint gods