Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat notion reader add db content #17393

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

HenryRoutson
Copy link

@HenryRoutson HenryRoutson commented Dec 30, 2024

Description

unfinished currently, i am still working on this currently
putting this up to make sure no one does the same thing
and for feedback

working on fixing a number of bugs including

  • type errors
  • only downloading max 100 pages

And adding features

  • notion database content download
  • optional print progress indicators for long tasks

And most importantly
improved code quality,
with logic related to pagination and requests becoming more encapsulated

Fixes # (issue)

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

i can add unit tests in future,
but for now i am using a large notion database as a realistic testing environment

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 30, 2024
@HenryRoutson
Copy link
Author

if this is likely to get merged just let me know

@logan-markewich
Copy link
Collaborator

@HenryRoutson if it works, it'll get merged -- net new features are nice :)

@HenryRoutson
Copy link
Author

Thanks! Just a heads up i am still working on it.

@logan-markewich logan-markewich marked this pull request as draft January 17, 2025 01:18
@logan-markewich
Copy link
Collaborator

Converting to draft since its still in progress (afaik)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants