Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prompt stacking in bedrock converse #17613

Merged

Conversation

GinkREAL
Copy link
Contributor

@GinkREAL GinkREAL commented Jan 24, 2025

Description

Bedrock converse edits self.system_prompt every time any chat function is called. This causes the system_prompt to keep bloating on its own due to the following chain of events:

  • _extend_messages in llm.py adds the class level system prompt to the messages array
  • messages_to_converse_messages combines the class level and chat level system prompt
  • chat functions assign this combined system prompt back to the class level system prompt
  • rinse and repeat, the class level system prompt endlessly grows

Fixes #17265

New Package?

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@GinkREAL GinkREAL marked this pull request as ready for review January 24, 2025 10:26
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 24, 2025
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 24, 2025
@logan-markewich logan-markewich merged commit 19c177c into run-llama:main Jan 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: BedrockConverse updating the system_prompt affects different chat_engines
2 participants