Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orchestrator options, and maintenance #58

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

sorenmat
Copy link

@sorenmat sorenmat commented Oct 6, 2020

This is work based upon #29 and addresses #31

The code is split into two commits one with actual code and one with the vendoring

This allow us to configure the orchestrator options for Rundeck

Added automated Acceptance tests, and updated go modules

@sorenmat sorenmat force-pushed the feature/orchestrator branch from aba7c28 to f1e330f Compare October 7, 2020 07:46
@sorenmat sorenmat marked this pull request as draft October 7, 2020 07:53
@sorenmat sorenmat force-pushed the feature/orchestrator branch from f1e330f to cd30969 Compare October 7, 2020 08:01
@sorenmat sorenmat marked this pull request as ready for review October 7, 2020 08:29
@sorenmat
Copy link
Author

Adding @ProTip for a possible review?

@sorenmat
Copy link
Author

Any change for a review, or suggestions?

@ProTip
Copy link
Contributor

ProTip commented Dec 18, 2020

Hi @sorenmat ,

Thanks for this and sorry for the late response.. I'm planning on reviewing all PRs thoroughly early next week.

In the meantime:

  • Is the Go upgrade necessary for the added functionality?
    It may be better to upgrade in a separate PR

  • Could you rebase on master?
    A basic test harness has been setup to run acceptance tests on CircleCI. That should get it running.

Thanks!

@bmx0r
Copy link

bmx0r commented Aug 26, 2021

any chance to have this feature merge soon? it would really help me :)

Soren Mathiasen added 2 commits September 16, 2021 12:14
This allow us to configure the orchestrator options for rundeck

Added automated Acceptance tests, and updated go modules
@sorenmat sorenmat force-pushed the feature/orchestrator branch 4 times, most recently from cfda966 to ba11912 Compare September 16, 2021 10:23
And upgraded to go 1.15
@sorenmat sorenmat force-pushed the feature/orchestrator branch from ba11912 to b5901cf Compare September 16, 2021 10:24
@sorenmat
Copy link
Author

@ProTip removed all the nice to have stuff, and left only the code functionality. Please review :)

@fardin01
Copy link

@qualman @fdevans @ltamaster Any chance one of you could review and merge this, please?

@Wicaeed
Copy link

Wicaeed commented Dec 2, 2021

Any chance this can be merged soon? It would be awesome to manage these settings in TF!

@fdevans
Copy link
Contributor

fdevans commented Feb 2, 2022

This is missing the Highest/Lowest Orchestrator option. Was that intentional? If so, why?

Screen Shot 2022-02-02 at 2 33 52 PM

.

@sorenmat
Copy link
Author

@fdevans I'm no longer with the company that used this feature :|
So not able to test it out anymore, but as I recall those attributes wasn't there when the PR was open. Might be wrong though.

@fdevans
Copy link
Contributor

fdevans commented Oct 9, 2023

OK. If anyone wants to finish this out with the remaining options we will review and approve. I will merge the head start to a branch on this repo for anyone that wants to try to finish it up.

@fdevans fdevans changed the base branch from master to Orchestrator October 9, 2023 20:20
@fdevans fdevans merged commit 699e93a into rundeck:Orchestrator Oct 9, 2023
3 checks passed
@fdevans fdevans mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants