-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add orchestrator options, and maintenance #58
Conversation
aba7c28
to
f1e330f
Compare
f1e330f
to
cd30969
Compare
Adding @ProTip for a possible review? |
Any change for a review, or suggestions? |
Hi @sorenmat , Thanks for this and sorry for the late response.. I'm planning on reviewing all PRs thoroughly early next week. In the meantime:
Thanks! |
any chance to have this feature merge soon? it would really help me :) |
This allow us to configure the orchestrator options for rundeck Added automated Acceptance tests, and updated go modules
cfda966
to
ba11912
Compare
And upgraded to go 1.15
ba11912
to
b5901cf
Compare
@ProTip removed all the nice to have stuff, and left only the code functionality. Please review :) |
@qualman @fdevans @ltamaster Any chance one of you could review and merge this, please? |
Any chance this can be merged soon? It would be awesome to manage these settings in TF! |
@fdevans I'm no longer with the company that used this feature :| |
OK. If anyone wants to finish this out with the remaining options we will review and approve. I will merge the head start to a branch on this repo for anyone that wants to try to finish it up. |
This is work based upon #29 and addresses #31
The code is split into two commits one with actual code and one with the vendoring
This allow us to configure the orchestrator options for Rundeck
Added automated Acceptance tests, and updated go modules