-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cfg-if
and noop-proc-macro
crates
#19
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 4 4
Lines 923 923
=======================================
Hits 614 614
Misses 309 309 ☔ View full report in Codecov by Sentry. |
We'd need to add a wasm target and serialize/deserialize tests to make sure we do not break stuff. If it makes a v_frame consumer lighter it could land, but I'd rather not risk breaking stuff we hardly test. |
I think these macros are just helpers to simplify
|
I mean in the future, not having to sprinkle cfg_attr across the codebase is nice since you cannot miss one when you add code. |
Ah, I see what you mean. I think the risk of that is relatively low, but if it's a point of concern then feel free to close this. |
Can we add a |
I think expanding the CI tests makes sense. Can you open an issue for it? It's a bit out of scope for this PR. |
Can this one be unblocked due to ac33688? |
I need to at least rebase this because the |
c5a6bc7
to
a7e641c
Compare
a7e641c
to
cbee199
Compare
Small hiccup while rebasing, should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Would like approval from @lu-zero on this one though due to prior conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for following through :)
This isn't very important, but it feels like these crates don't add much value in this project. I guess they were used in rav1e and just kept as-is?
I think that cfg-if is unnecessary for simple cfg attributes like this, and the noop_proc_macro is used so rarely that it barely reduces the amount of code.