Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV of core crates to 1.56.0 #2906

Closed

Conversation

brody4hire
Copy link
Contributor

@brody4hire brody4hire commented Jan 7, 2025

STATUS:

I think the following PRs should be merged first to resolve the CI build issues:

I would be happy to rebase & squash with a clean commit message once the PRs above are reviewed & merged.


WHY:

This should allow the following updates I proposed in other PRs:


open question(s):

  • This PR proposed exact core MSRV, while other PR proposes less exact general MSRV - see Bump general MSRV to 1.63 #2907 - I would be happy to change either of these to improve consistency if needed. I made this one more exact since there is also Rust version 1.56.1.
  • I wonder if we should just use the same MSRV in all crates to keep things a little simpler. I would be happy to close this and update the MSRV for all crates in PR Bump general MSRV to 1.63 #2907.

@brody4hire brody4hire marked this pull request as ready for review January 7, 2025 02:20
@brody4hire brody4hire mentioned this pull request Jan 7, 2025
3 tasks
brody4hire added a commit to brody4hire/futures-rs that referenced this pull request Jan 7, 2025
@brody4hire brody4hire marked this pull request as draft January 7, 2025 02:57
brody4hire

This comment was marked as outdated.

@brody4hire brody4hire changed the title Bump MSRV of core crates to 1.41.0 Bump MSRV of core crates to 1.56.0 Jan 7, 2025
@taiki-e
Copy link
Member

taiki-e commented Jan 14, 2025

Closing as #2908 and #2909 are closed.

Thanks anyway for the PR.

@taiki-e taiki-e closed this Jan 14, 2025
@brody4hire brody4hire deleted the core-crates-msrv-1.41.0 branch January 14, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants