Skip to content

Commit

Permalink
Merge pull request #1423 from ArhanChaudhary/docs-elaboration
Browse files Browse the repository at this point in the history
Be more explicit with available wasm-opt flags in documentation
  • Loading branch information
drager authored Nov 2, 2024
2 parents ba5fef3 + 6f33393 commit 32e52ca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions docs/src/cargo-toml-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ The available configuration options and their default values are shown below:
# be set to an array of strings which are explicit arguments to pass to
# `wasm-opt`. For example `['-Os']` would optimize for size while `['-O4']`
# would execute very expensive optimizations passes
#
# In most cases, the `-O[X]` flag is enough. However, if you require extreme
# optimizations, see the full list of `wasm-opt` optimization flags
# https://github.com/WebAssembly/binaryen/blob/version_117/test/lit/help/wasm-opt.test
wasm-opt = ['-O']

[package.metadata.wasm-pack.profile.dev.wasm-bindgen]
Expand Down
2 changes: 1 addition & 1 deletion src/install/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ pub fn prebuilt_url_for(tool: &Tool, version: &str, arch: &Arch, os: &Os) -> Res
Tool::WasmOpt => {
Ok(format!(
"https://github.com/WebAssembly/binaryen/releases/download/{vers}/binaryen-{vers}-{target}.tar.gz",
vers = "version_117",
vers = "version_117", // Make sure to update the version in docs/src/cargo-toml-configuration.md as well
target = target,
))
}
Expand Down

0 comments on commit 32e52ca

Please sign in to comment.