-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated to package:web #1087
base: minor
Are you sure you want to change the base?
Migrated to package:web #1087
Conversation
Is this a breaking change? (Since it is to be merged into |
It's been quite a while, but there are no library API changes. only changes to how web APIs are called. I only tested it with the example project and it worked without any modifications. |
That's as expected, so I think this could be rebased to |
Any ETA on this PR? |
@ali2236 Would you move this PR to the minor branch? (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request) |
@mtallenca I'll see what I can do. |
Thanks @ali2236 ! @ryanheise Anything else needs to be done for this PR? |
Sorry, I've just been in hospital and recovering so I'm not currently in a good condition to review/merge just yet, but let's give it 2-3 days and see how I'm feeling. |
@ryanheise Sorry to hear you are in hospital recovering. Hope you get better soon. Please let me know if there is anything I can help out with regarding the repo. |
@ali2236 Following up, will this be supporting WASM?? |
Yes. this removes the old js dependency and replaces it with the new wasm compatible web package |
I'm starting to feel somewhat better. I'm going to sleep now but will take a look at this the next day. |
Unfortunately this is going to be rather complicated to merge. A rebase would have been nice, but I think a merge has been done instead, hence it saying there are now 49 commits to be merged into |
Glad you are feeling better. Let me know if there is anything I could do to help out. |
I've put my changes in a new PR here: #1102 if you'd like to test. It cherry picks the key commits from this PR, updates versions, fixes nullability and formatting. |
Migrated
audio_service_web
to usepackage:web
instead ofdart:html
,dart:js
&dart:js_util
.I also updated the example app and tested with it to see if the new web changes were working.
Pre-launch Checklist
minor
branch OR my change is breaking and lands inmajor
branch.pubspec.yaml
according to the [pub versioning philosophy].* DESCRIPTION OF YOUR CHANGE (@your-git-username)
).///
).dart analyze
.dart format
.flutter test
and all tests are passing.