feature: warn about missing files #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rage itself does not have good error messages when files are missing, so add some of our own checks and warnings.
|
I tested missing identity paths on my computer. The warning appears, but also rage fails if only one of the list of identityPaths is missing. Seems like ideally it would only crash if none of the identityPaths can decrypt the secret. |
|
I made an upstream issue report about this str4d/rage#294 |
cole-h
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rage itself does not have good error messages when files are missing,
so add some of our own checks and warnings.
I haven't had a chance to test this yet.