Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/goreleaser upgrade #255

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Conversation

insaaniManav
Copy link
Contributor

Upgraded goreleaser to v2

.github/workflows/goreleaser.yml Outdated Show resolved Hide resolved
.github/workflows/goreleaser.yml Outdated Show resolved Hide resolved
@abhisek
Copy link
Member

abhisek commented Oct 17, 2024

@insaaniManav Thanks for the PR. Are you able to run the goreleaser binary with this config locally? I don't have a good way to test this without triggering a release.

@insaaniManav
Copy link
Contributor Author

@insaaniManav Thanks for the PR. Are you able to run the goreleaser binary with this config locally? I don't have a good way to test this without triggering a release.

yup here is a dry run https://github.com/insaaniManav/vet/actions/runs/11379032341 - will make the requested changes - trigger another dry run and then get back here

@insaaniManav
Copy link
Contributor Author

@abhisek I have pinned the commit hash in the run , also I have set the version to '~> v2' which is the official recommend thing , here is the successful workflow https://github.com/insaaniManav/vet/actions/runs/11381193881

Copy link
Member

@abhisek abhisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor feedback added.

.github/workflows/goreleaser.yml Show resolved Hide resolved
.github/workflows/goreleaser.yml Show resolved Hide resolved
@abhisek abhisek merged commit 763772c into safedep:main Oct 18, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants