LLVM 16.0.6 #4
Open
LLVM 16.0.6 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting observation:
EDIT: sailfishos/cmake@817763e it's already taken care of. Good :-) |
rpmlint doesn't like the output on aarch64 |
With a lot of thanks to @direc85 for providing the patches for the patches and the build machine. I'll use said build machine now to get some recentish version of Rust to work :-) |
This comment was marked as outdated.
This comment was marked as outdated.
|
Disregard the previous comment -- all I had to do to make other architectures build out of the box was clearing the build cache before compiling the next one: |
This is a first-thing-that-worked patch to fix compiler error: > ninja: error: '/usr/lib64/libz.so', needed by 'bin/clang-tblgen', > missing and no known rule to make it Apparently it doesn't work on i486, likely due to cross compilation.
mlehtima
reviewed
Mar 16, 2024
| @@ -153,7 +153,7 @@ pushd build | |||
| %endif | |||
| -DCLANG_INCLUDE_TESTS:BOOL=OFF \ | |||
| -DLLVM_MAIN_SRC_DIR=%{_datadir}/llvm/src \ | |||
| %if 0%{?__isa_bits} == 64 | |||
| %ifarch aarch64 | |||
There was a problem hiding this comment.
Why this change? This limits the usage for only aarch64 ignoring for example x86_64, I would prefer using the old way unless there are some issues with that?
There was a problem hiding this comment.
@direc85 do you know why you pushed this?
There was a problem hiding this comment.
If __isa_bits doesn't work you can also compare against %{_lib}.
There was a problem hiding this comment.
This was due to not clearing the previous build folder before changing architecture, so that change can be reverted.
|
clang build failed with |
Thaodan
reviewed
Apr 1, 2024
| @@ -153,7 +153,7 @@ pushd build | |||
| %endif | |||
| -DCLANG_INCLUDE_TESTS:BOOL=OFF \ | |||
| -DLLVM_MAIN_SRC_DIR=%{_datadir}/llvm/src \ | |||
| %if 0%{?__isa_bits} == 64 | |||
| %ifarch aarch64 | |||
There was a problem hiding this comment.
Suggested change
| %ifarch aarch64 | |
| %if "%{_lib}" == "lib64" |
This should be much better ^
Same for me here. Using Ubuntu packages as reference, it looks clang-tools-15 has them, but clang-tools-16 does not. I'll prepare a PR for this next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm leaving this to compile overnight, no need to test this yet.
See #3 for the explanation of my plan.