Remove user-agent filter #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer forbidden: https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_header_name Note: The User-Agent header is no longer forbidden, as per spec — see forbidden header name list (this was implemented in Firefox 43) — it can now be set in a Fetch Headers object, or with the setRequestHeader() method of XMLHttpRequest. However, Chrome will silently drop the header from Fetch requests (see Chromium bug 571722).
|
Change could be fine, but is there some rationale for doing it? XHR from qtdeclarative shouldn't generally happen that much and when it does, does it matter much what's the useragent? Hence pondering do we need to add delta here. |
|
That would allow setting custom 'user-agent' header from QML when using XHR which seeing as we're getting filtered by cloudflare and similar would hopefully help devs trying to avoid those blocks. At least currently it's ignored and I believe that piece of code is what's filtering it.
…On Tuesday, 6 June 2023, Pekka Vuorela wrote:
Change could be fine, but is there some rationale for doing it? XHR from qtdeclarative shouldn't generally happen that much and when it does, does it matter much what's the useragent? Hence pondering do we need to add delta here.
--
Reply to this email directly or view it on GitHub:
#9 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***
--
Sent from my Jolla
|
|
So suppose you have some app using QML XMLHttpRequest API? Did you test that this change fixes problems related to that? |
|
I was just playing with xhr from qml and a free hosting provider and noticed that changing user-agent did not result in change in received headers on server side, went digging what that was about and found user-agent being filtered here. The same proposed change was done in main qt in 2020: sailfishos-mirror/qtdeclarative@d6091eb
I guess I missed the test part
…On Tuesday, 6 June 2023, Pekka Vuorela wrote:
So suppose you have some app using QML XMLHttpRequest API? Did you test that this change fixes problems related to that?
--
Reply to this email directly or view it on GitHub:
#9 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***
--
Sent from my Jolla
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer forbidden for XHR:
https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_header_name
Note: The User-Agent header is no longer forbidden, as per spec — see forbidden header name list (this was implemented in Firefox 43) — it can now be set in a Fetch Headers object, or with the setRequestHeader() method of XMLHttpRequest. However, Chrome will silently drop the header from Fetch requests (see Chromium bug 571722).