SAK-50754 sitearchive Cleanup some code and add unit tests #13106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfish
force-pushed
the
SAK-50754
branch
3 times, most recently
from
260da50 to
8f033cb
Compare
|
Could somebody take a look at the config for the windows tests? The archive and merge tests in this PR create directories in the OS's tmp directory to simulate SAKAI_HOME/sakai/archive. On the unix builds, the tests run fine, but not on the windows build. I see this in the build output: 03-Jan-2025 10:50:34.015 WARN [main] o.s.a.i.SiteMerger.merge merge(): file not permitted: C:\Users\runneradmin\AppData\Local\Temp\junit8549310033587694471\archive\xyz-archive the junit85... dir is supposed to be created by JUnit's TemporaryFolder, and then the test code creates the subdirectories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-50754