Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults: remove elasticsearch.url #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ze42
Copy link

@ze42 ze42 commented Oct 2, 2019

Not supported anymore on ES 7.x+

Not supported anymore on ES 7.x+
@myii
Copy link
Member

myii commented Oct 2, 2019

@ze42 Just general feedback. Please also consider what needs to be done with the following lines:

# The Elasticsearch instance to use for all your queries.
# elasticsearch.url: "http://localhost:9200"

config:
elasticsearch.url: "http://localhost:9200"

@ze42
Copy link
Author

ze42 commented Oct 2, 2019

@ze42 Just general feedback. Please also consider what needs to be done with the following lines:

First might be updated to specify it is about ES5?
mmm... 2nd might be kept as an example, as it uses es 5.

But yeah, it could probably benefit from having example that would match a more recent version of ES... not sure I'm in best position to do that, not having much idea how it works to start with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants