Replace SharpCompress with System.IO.Compression #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @otykier ! |
|
Oh, I did not, sorry. I just assumed everything would work since all unit tests passed, lol. I did test that the .xlsx files generated with this change can be opened in Excel. Haven't tried LibreOffice. But come to think of it, I didn't even pass the ZIP64-flag on to the System.IO.Compression.ZipArchive class. There's not really a lot of configuration options in ZipArchive, and specifically, I don't see that there's an option regarding ZIP64-enabling? Do you know if there's a way to configure ZipArchive to use ZIP64? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the SharpCompress dependency, relying instead on System.IO.Compression. With this change, LargerXlsx will no longer have any dependencies outside of .NET.