Gather compilation error of custom type tags too. #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user defines wrong custom type tag with invalid validation script, it had immediately thrown compilation error. Besides, other user mistakes had been kept by `typia` for reporting them at once. Therefore, the validation script error on the custom type tag may hide every other mistakes. This PR fixes such immidately throwing exception problem from custom type tag, so that makes user convenient like other user-mistaken based error cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user defines wrong custom type tag with invalid validation script, it had immediately thrown compilation error. Besides, other user mistakes had been kept by
typiafor reporting them at once. Therefore, the validation script error on the custom type tag may hide every other mistakes.This PR fixes such immidately throwing exception problem from custom type tag, so that makes user convenient like other user-mistaken based error cases.