Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to build arm64 image #2732

Closed

Conversation

kkimurak
Copy link
Contributor

@kkimurak kkimurak commented Mar 17, 2023

This PR allow us to build arm64 image in addition to currently supported amd64.

Originally I have posted a patch to #2603 . I would love to hear your thoughts (and hopefully reports on how it works) from the community here - including whether or not we should support it.

Also please note that this PR does not modify CI configuration - This is to ensure that this change does not break existing amd64 image builds and continues to work.

You can test this PR after applying the patch and run docker buildx build --platform linux/arm64 .

@kkimurak kkimurak force-pushed the support-multi-platform-build branch from b8ba114 to e40699e Compare March 17, 2023 09:41
@kkimurak
Copy link
Contributor Author

Made sure to pass shellcheck.

@kkimurak kkimurak changed the title support build on amd64 and arm64 Add support to build arm64 image Mar 17, 2023
@kkimurak kkimurak force-pushed the support-multi-platform-build branch from e40699e to 4916c58 Compare March 17, 2023 10:24
@kkimurak
Copy link
Contributor Author

Corrected download message (uninitialized variable in use).

@kkimurak kkimurak marked this pull request as ready for review March 19, 2023 23:47
@kkimurak kkimurak force-pushed the support-multi-platform-build branch from 4916c58 to 8e0373e Compare April 17, 2023 07:24
@kkimurak
Copy link
Contributor Author

rebased onto 15.10.3

@kkimurak kkimurak force-pushed the support-multi-platform-build branch from 8e0373e to 015c446 Compare May 12, 2023 02:00
@kkimurak
Copy link
Contributor Author

rebased onto 15.11.3

@kkimurak kkimurak force-pushed the support-multi-platform-build branch from 015c446 to 6e96cd7 Compare May 26, 2023 00:15
@kkimurak kkimurak force-pushed the support-multi-platform-build branch 2 times, most recently from 4254f50 to 8bbb383 Compare June 9, 2023 11:09
@kkimurak
Copy link
Contributor Author

kkimurak commented Jun 9, 2023

rebased onto 16.0.3.

If there is no plan to merge this work, it would be helpful if you could close it and state that there are no plans to prepare an image for the ARM64 platform.

@sachilles
Copy link
Collaborator

@kkimurak Apologies for my poor availability.

In principle I don't see any problems by supporting ARM64 if there are contributors that support this work an help to publish the corresponding images regularly. So far I didn't provide images for multiple architectures und thus, I'll need help on this.

@Jack12816
Copy link
Contributor

Jack12816 commented Jun 24, 2023

I would love to see this merged and made available. <3 Thanks for the contribution @kkimurak!

Maybe this could help here to enable a multi-arch build via CircleCI.

I guess --platform=linux/amd64,linux/arm64 must be added to the docker build commands:

and the docker push works transparently.

@sachilles It would be great if you could merge this PR with the CI addition and see if CI is working properly. If not revert it - then we could iterate on this. :)

Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Jul 20, 2023
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
The build platform mostly depends on golang
@kkimurak kkimurak force-pushed the support-multi-platform-build branch from 8bbb383 to 3b2bed4 Compare August 1, 2023 03:20
@kkimurak
Copy link
Contributor Author

kkimurak commented Aug 1, 2023

rebased onto 16.2.1.

@gjrtimmer
Copy link
Contributor

I would really love this, waiting for my RK1 modules from turing pi. With this I can run my GitLab on my Turing PI.

Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Aug 9, 2023
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Aug 9, 2023
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Aug 9, 2023
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Aug 9, 2023
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Aug 9, 2023
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
@kkimurak
Copy link
Contributor Author

kkimurak commented Oct 9, 2023

Sorry for delay but

  • I'm not going to maintain CI settings (as I stated at first)
  • I've lost motivation because the only ARM64 device I owned broke.
  • There is a concurrent work support arm architecture #2803. This can be confusing, and I think discussions with the same content should be grouped together (i.e. one should be closed).

I hope someone who need this will take over (or #2803 - not exactly same code but works) .

I apologize again for my selfish actions.

@kkimurak kkimurak closed this Oct 9, 2023
Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Feb 4, 2024
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Feb 4, 2024
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Jack12816 added a commit to Jack12816/docker-gitlab that referenced this pull request Jul 12, 2024
Stolen from sameersbn#2732

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants