-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to build arm64 image #2732
Conversation
b8ba114
to
e40699e
Compare
Made sure to pass shellcheck. |
e40699e
to
4916c58
Compare
Corrected download message (uninitialized variable in use). |
4916c58
to
8e0373e
Compare
rebased onto 15.10.3 |
8e0373e
to
015c446
Compare
rebased onto 15.11.3 |
015c446
to
6e96cd7
Compare
4254f50
to
8bbb383
Compare
rebased onto 16.0.3. If there is no plan to merge this work, it would be helpful if you could close it and state that there are no plans to prepare an image for the ARM64 platform. |
@kkimurak Apologies for my poor availability. In principle I don't see any problems by supporting ARM64 if there are contributors that support this work an help to publish the corresponding images regularly. So far I didn't provide images for multiple architectures und thus, I'll need help on this. |
I would love to see this merged and made available. <3 Thanks for the contribution @kkimurak! Maybe this could help here to enable a multi-arch build via CircleCI. I guess
and the @sachilles It would be great if you could merge this PR with the CI addition and see if CI is working properly. If not revert it - then we could iterate on this. :) |
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
The build platform mostly depends on golang
8bbb383
to
3b2bed4
Compare
rebased onto 16.2.1. |
I would really love this, waiting for my RK1 modules from turing pi. With this I can run my GitLab on my Turing PI. |
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Sorry for delay but
I hope someone who need this will take over (or #2803 - not exactly same code but works) . I apologize again for my selfish actions. |
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Stolen from sameersbn#2732 Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
This PR allow us to build arm64 image in addition to currently supported amd64.
Originally I have posted a patch to #2603 . I would love to hear your thoughts (and hopefully reports on how it works) from the community here - including whether or not we should support it.
Also please note that this PR does not modify CI configuration - This is to ensure that this change does not break existing amd64 image builds and continues to work.
You can test this PR after applying the patch and run
docker buildx build --platform linux/arm64 .