Add configuration option to hide todo edges on the graph #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catsuko
commented
Aug 17, 2024
Comment on lines
+62
to
+67
| allow(DeprecatedReferencesLoader) | ||
| .to receive(:new) | ||
| .with(images_package, an_instance_of(Pathname)) | ||
| .and_return(deprecated_references_loader_for_images) | ||
| allow(PackageTodoLoader).to receive(:new).and_call_original | ||
| expect(PackageTodoLoader) | ||
| allow(PackageTodoLoader) |
There was a problem hiding this comment.
I changed this from expect to allow since it was breaking my test case.
Personally I think the existing specs already check that the todos are drawn so there is no need to also check internal classes are being called in some particular way but let me know if you would prefer to keep these expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the ability to draw the todo violations however in some cases I want to be able to see a clean dependency graph as well. This PR adds a configuration option to hide the todo edges. By default it will show them to keep existing behaviour the same.
Related pull requests: