feat(lib): more informative logging #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ fix related docs parsing + catch and log errors + improve queue utility
+ debugging & instructions + fix finding references in arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
queuenow returns a tuple of[results, errors]instead of justresults. TheCatchableErrorstores the function & parameters that failed, so with some more build-out we can use it to re-try failed requests.You can see how we're using this in tablet here
:)
Here's a loom video that explains a bit about how it works and some big changes in this PR:
https://www.loom.com/share/ffe3609900434c098458ccce65ee296b